This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove unused _TypeNone enum field. #14440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aam
changed the title
dnfield
reviewed
Dec 12, 2019
lib/ui/painting.dart
Outdated
| final int _type; | ||
|
|
||
| // The type of SkColorFilter class to create for Skia. | ||
| // These constants must be kept in sync with ColorFilterType in paint.cc. |
Contributor
There was a problem hiding this comment.
This line is no longer true and should just be removed.
dnfield
reviewed
Dec 12, 2019
lib/ui/painting.dart
Outdated
Comment on lines
2636
to
2637
| // ignore:unused_field | ||
| static const int _TypeNone = 0; // null |
Contributor
There was a problem hiding this comment.
Rather than adding an ignore, let's just remove the unused field.
We should also do the same in the web_ui painting.dart
Member
Author
There was a problem hiding this comment.
There is no _TypeNone in web_ui painting.dart as far as I can tell
Member
Author
There was a problem hiding this comment.
Rather than adding an ignore, let's just remove the unused field.
Done
Contributor
There was a problem hiding this comment.
It's in lib/web_ui/lib/src/engine/color_filter.dart, line 118
Member
Author
There was a problem hiding this comment.
Ah, got you. Interestingly this is not picked up by analyzer as unused field.
aam
changed the title
This was referenced Dec 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_TypeNone is not used and that triggers hint in dart analyzer since dart 2.7.0